Skip to content

build: add explanation comment to confirmModulesPurge setting#3694

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:pnpm-purge
May 27, 2026
Merged

build: add explanation comment to confirmModulesPurge setting#3694
alan-agius4 merged 1 commit into
angular:mainfrom
alan-agius4:pnpm-purge

Conversation

@alan-agius4
Copy link
Copy Markdown
Contributor

Add to the confirmModulesPurge: false setting in pnpm-workspace.yaml.

Add to the `confirmModulesPurge: false` setting in
`pnpm-workspace.yaml`.
@alan-agius4 alan-agius4 requested a review from josephperrott May 21, 2026 09:17
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 21, 2026
@angular-robot angular-robot Bot added the area: build & ci Related the build and CI infrastructure of the project label May 21, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pnpm-workspace.yaml configuration by setting confirmModulesPurge to false. This change prevents pnpm from prompting for confirmation when it determines that the node_modules directory needs to be purged and recreated. I have no feedback to provide as there are no review comments to evaluate.

Copy link
Copy Markdown
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 merged commit 64047f9 into angular:main May 27, 2026
12 checks passed
@alan-agius4
Copy link
Copy Markdown
Contributor Author

This PR was merged into the repository. The changes were merged into the following branches:

@alan-agius4 alan-agius4 deleted the pnpm-purge branch May 27, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants